feat: better reject null characters in forms#7472
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom May 28, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7472 +/- ##
==========================================
- Coverage 88.98% 88.91% -0.08%
==========================================
Files 291 294 +3
Lines 40717 41196 +479
==========================================
+ Hits 36233 36630 +397
- Misses 4484 4566 +82 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Django's
forms.ModelMultipleChoiceFieldwith a subclass that applies theProhibitNullCharactersValidatorto the submitted values before calling the superclassclean()method. This works around an apparent bug in Django that causes it to throw a server error instead of properly marking the form as invalid.We've mostly seen this abused in the
SearchForm, but I've preemptively replaced all our use of the field class.